Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop AsyncFileCopy and some random seemingly unused stuff #10491

Merged
merged 3 commits into from Sep 22, 2016

Conversation

@Jalle19
Copy link
Member

commented Sep 18, 2016

Description

Just some minor things I've found while trying to pick up coding on Kodi again.

Motivation and Context

Gotta start somewhere

How Has This Been Tested?

It seems to build

@Jalle19 Jalle19 changed the title Drop random utils Drop AsyncFileCopy and some random seemingly unused stuff Sep 18, 2016
@Jalle19

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

Is it normal for the unit tests to fail when built with Clang? @MartijnKaijser ?

@Paxxi

This comment has been minimized.

Copy link
Member

commented Sep 19, 2016

Unit test fail sometimes on Linux currently. Not the tests themselves but it crashes before results can be written.

Changes look fine

@Jalle19

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

jenkins build this please

@Jalle19

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2016

@Paxxi good to go? Jenkins seemed happy.

@Paxxi

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

I think we agreed at de con that only fixes would be merged until we branch so hold of on it for a bit

@Jalle19

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2016

I must have missed that part because it's been pointed out twice and I'm always surprised :D

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

I'd say more of minor cleaning up is still OK. Just no big refactoring and features

@Paxxi Paxxi merged commit 48b57c8 into xbmc:master Sep 22, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta3 milestone Sep 22, 2016
@tamland

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Broke build: https://github.com/xbmc/xbmc/blob/master/xbmc/utils/Makefile.in#L4 How did this pass jenkins?

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

@tamland jenkins only build cmake nowdays.

ksooo added a commit to ksooo/xbmc that referenced this pull request Sep 22, 2016
bkuhls added a commit to bkuhls/xbmc that referenced this pull request Sep 22, 2016
Fix Makefile after xbmc#10491 (removal of AsyncFileCopy.(cpp|h)
Paxxi added a commit that referenced this pull request Sep 22, 2016
Fix autoconf-based build after #10491.
ksooo added a commit that referenced this pull request Sep 22, 2016
[macos][ios] fix xcode project after #10491.
@Jalle19

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2016

https://imgflip.com/i/1b3gmz

Sorry about that, will take the old/current build system into account the next time.

@Jalle19

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2016

s/brake/break/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.