Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[estouchy] exit button should execute the selected shutdown function #10513

Merged
merged 1 commit into from Sep 20, 2016

Conversation

@ronie
Copy link
Member

commented Sep 19, 2016

quit may not be applicable on some platforms, use the selected shutdown function instead.

http://forum.kodi.tv/showthread.php?tid=262145&pid=2418740#pid2418740

@mention-bot

This comment has been minimized.

Copy link

commented Sep 19, 2016

@ronie, thank you for improving kodi! According to the last 5 commits, we found the potential reviewers: @tamland . Final approval needs to be given by the componenent maintainer.

@ksooo

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

Didn't we have an agreement only to include fixes for Krypton after beta2?

@ronie ronie changed the title [estouchy] exit button should execute the selected as shutdown function [estouchy] exit button should execute the selected shutdown function Sep 20, 2016

@ronie ronie force-pushed the ronie:estouchy-quit branch from 6e459e8 to 1c93f1d Sep 20, 2016

@ronie

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2016

perhaps i should've tagged it fix, i dunno..
it fixes the problem, but it's also a behaviour change.

will tag it for v18, np.

@ksooo

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

Reading what it does, it sounds like a fix to me. We should actually label it "fix" and shove into Krypton i guess. ;-)

@ronie

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2016

you mean we should actually read stuff before we comment? ;-)

@ksooo

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

I mean we should use correct PR labels in the first place. :-)

@ronie ronie merged commit b4db09c into xbmc:master Sep 20, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ronie ronie deleted the ronie:estouchy-quit branch Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.