Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #16906 - Fix iEndOffset property when parsing cue files #10521

Merged
merged 1 commit into from Sep 21, 2016

Conversation

@iscy
Copy link
Contributor

commented Sep 21, 2016

Description

When CueDocument is parsing the cue file and generating the data, it blindly sets "iEndOffset" by assuming that the last track ends when the current one starts. This assumption is only right if the 'FILE' pointed by this cue sheet does not change. In the current case, each 'TRACK' has its own flac file, so this assumption is not right and PAPlayer will act on this data. Therefore, the files won't play since they will end shortly (immediately) after being started.

Motivation and Context

http://trac.kodi.tv/ticket/16906

How Has This Been Tested?

Once patched and the library re-imported, the album used for debugging could be played without problems.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@mention-bot

This comment has been minimized.

Copy link

commented Sep 21, 2016

@iscy, thank you for improving kodi! According to the last 5 commits, we found the potential reviewers: @PSyton, @Montellese and @phate89 . Final approval needs to be given by the componenent maintainer.

@kib kib added the Type: Fix label Sep 21, 2016

@FernetMenta FernetMenta added this to the Krypton 17.0-beta3 milestone Sep 21, 2016

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

thanks you very much
jenkins build this please

@FernetMenta FernetMenta self-assigned this Sep 21, 2016

@MartijnKaijser MartijnKaijser merged commit 7f905f0 into xbmc:master Sep 21, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.