it will be called by XBMC before shutting down.
aim is to replace xbmc.abortRequested and have xbmc.Monitor notify the script once XBMC wants us to shutdown instead of checking for xbmc.abortRequested in a while loop.
xbmc.abortRequested is still in but if we are doing API bump and are braking addons in future, it might be a good idea to remove it.
extend xbmc.Monitor with onAbortRequested(), it will be called by XBM…
…C before shutting down.
seems rather limited to not use some handle. now it can only be used to kill all scripts...
would you want to be able to pass addon ID or addon instance? and if nothing is passed in, we kill all?
allow xbmc to kill specific Addon ID, if not supplied we kill all addons
looks fine. next step would be to use the new stuff in the core but that we can punt for later
Merge pull request #1053 from amet/onAbortRequested
extend xbmc.Monitor with onAbortRequested()
04:42:40 T:8816 NOTICE: StorageServer-1.0.0 Closed down
04:42:44 T:14376 ERROR: XBPyThread::stop - script didn't stop in proper time - lets kill it
Yes, I confirm. I had to remove the common plugin cache script to work around this issue.
EDIT: I'm using Windows 7
In any case it's not OK.
@wsoltys, @amet, will someone fix or revert it?
On Slackware Linux also XBMC doesn't quit after this PR
@Karlson2k patience please.... otherwise submit the patch
@amet, no problem.
I'm working on other patches. :)