extend xbmc.Monitor with onAbortRequested() #1053

Merged
merged 2 commits into from Jul 3, 2012

Conversation

Projects
None yet
4 participants
Contributor

amet commented Jun 7, 2012

it will be called by XBMC before shutting down.

aim is to replace xbmc.abortRequested and have xbmc.Monitor notify the script once XBMC wants us to shutdown instead of checking for xbmc.abortRequested in a while loop.

xbmc.abortRequested is still in but if we are doing API bump and are braking addons in future, it might be a good idea to remove it.

Cheers,
amet

@ghost

ghost commented Jun 7, 2012

seems rather limited to not use some handle. now it can only be used to kill all scripts...

Contributor

amet commented Jun 9, 2012

@cptspiff
would you want to be able to pass addon ID or addon instance? and if nothing is passed in, we kill all?

@ghost

ghost commented Jun 27, 2012

looks fine. next step would be to use the new stuff in the core but that we can punt for later

@amet amet added a commit that referenced this pull request Jul 3, 2012

@amet amet Merge pull request #1053 from amet/onAbortRequested
extend xbmc.Monitor with onAbortRequested()
ecc29a4

@amet amet merged commit ecc29a4 into xbmc:master Jul 3, 2012

Member

Karlson2k commented Jul 4, 2012

This merge breaks shutdown procedure. XBMC.exe can't exit. Last strings in log:

04:42:40 T:8816 NOTICE: StorageServer-1.0.0 Closed down
04:42:44 T:14376 ERROR: XBPyThread::stop - script didn't stop in proper time - lets kill it

Member

Voyager1 commented Jul 5, 2012

Yes, I confirm. I had to remove the common plugin cache script to work around this issue.
EDIT: I'm using Windows 7

Member

Karlson2k commented Jul 5, 2012

In any case it's not OK.
@wsoltys, @amet, will someone fix or revert it?

Contributor

otzy007 commented Jul 5, 2012

On Slackware Linux also XBMC doesn't quit after this PR

Contributor

amet commented Jul 5, 2012

@Karlson2k patience please.... otherwise submit the patch

Member

Karlson2k commented Jul 5, 2012

@amet, no problem.
I'm working on other patches. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment