Join GitHub today
Setting album user rating using album ID not GetAlbumIdByPath #10553
Fixes a bug when setting album user rating when the user has songs from more than one album in the same folder.
There is nothing to say that all albums must have a unique folder that does not contain songs from any other album, even if this is the common way to organise your music files. Path may not be sufficient to identify an album uniquely. Hence
Setting album user rating was using path to attempt to identify the album when the unique album ID is readily available. Switch to use ID not path.
To test this fix put music files from more than one album all in the same folder. Add folder as new music source and scan into music library. Edit the user rating for the different albums from the Album Info dialog, and see them being correctly applied when you look at the albums node (sorted by "my rating").
Without this fix when you change the user rating for an album once you leave the Album Info dialog then actual edit is always applied to the first album.
Sorry, I always forget how scrapping is done. So I didn't ment json, but
On Tue, Sep 27, 2016, 11:37 Dave Blake email@example.com wrote:
1 similar comment