Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] change signature for ListItem.setRating #10564

Merged
merged 1 commit into from Sep 26, 2016

Conversation

@phil65
Copy link
Member

commented Sep 26, 2016

At the moment the signature of ListItem.setRating contains a keyword argument called "def". Since this is a builtin keyword for python we should use something else for this, otherwise it cant be used explicitely. This PR adjusts it to use "defaultt", as we do in other parts of the API, too.
Also fixes some stuff in the docs.

@tamland

@mention-bot

This comment has been minimized.

Copy link

commented Sep 26, 2016

@phil65, thank you for improving Kodi! According to the last 5 commits, we found the potential reviewers: @phate89, @AlwinEsch and @tamland. Final approval needs to be given by the component maintainer.

@InuSasha

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2016

defaultt with two t's?

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 26, 2016

@InuSasha default is a keyword as well hence we use defaultt

@InuSasha

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2016

@MartijnKaijser ah good to know, sorry for the noise

@phil65

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

jenkins build this please

@phil65

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

I think this qualifies as a fix and can get merged?

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta3 milestone Sep 26, 2016
@MartijnKaijser MartijnKaijser merged commit 7b40d76 into xbmc:master Sep 26, 2016
2 of 3 checks passed
2 of 3 checks passed
jenkins.kodi.tv You are a failure. Fix the code and try again......
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phil65 phil65 deleted the phil65:python_setrating branch Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.