Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitignore] add addon packages, __.SYMDEF* and certificates #10566

Merged
merged 1 commit into from Oct 15, 2016

Conversation

@BigNoid
Copy link
Member

commented Sep 26, 2016

Add files that are untracked after building on my system to gitignore.

Description

Add visualisation, screensaver.pingpong and inputstream addons to gitignore
Add __.SYMDEF* to gitignore
Add system/certs to gitignore

Motivation and Context

These files keep popping up as untracked in my folder.

How Has This Been Tested?

The files no longer are marked as untracked

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@mention-bot

This comment has been minimized.

Copy link

commented Sep 26, 2016

@BigNoid, thank you for improving Kodi! According to the last 5 commits, we found the potential reviewers: @ronie, @Montellese and @opdenkamp. Final approval needs to be given by the component maintainer.

@BigNoid

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2016

Anyone opposed to merging this?

.gitignore Outdated
@@ -131,6 +131,9 @@ cmake_install.cmake
/addons/xbmc.json/addon.xml
/addons/kodi.guilib/addon.xml
/addons/audiodecoder.*
/addons/visualization.*
/addons/screensaver.pingpong/

This comment has been minimized.

Copy link
@hudokkow

hudokkow Oct 15, 2016

Member

/addons/screensaver.* ?

@hudokkow

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

Are you building in-tree? Those artifacts don't show for me with cmake.

@BigNoid

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2016

Are you building in-tree? Those artifacts don't show for me with cmake.

Yes building in tree on macOS.

@BigNoid BigNoid force-pushed the BigNoid:gitignore branch from b896c3a to 4e49a1d Oct 15, 2016
@hudokkow

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

I guess its good to go.
Hint, start building out-of-tree with cmake. 😉

@BigNoid BigNoid merged commit 63b8843 into xbmc:master Oct 15, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BigNoid BigNoid deleted the BigNoid:gitignore branch Oct 15, 2016
@hudokkow hudokkow added the Type: Fix label Oct 15, 2016
@hudokkow hudokkow added this to the Krypton 17.0-beta4 milestone Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.