Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util/darwin] - fix GetHomePath again - fixes osx unit tests #10574

Merged
merged 1 commit into from Sep 27, 2016

Conversation

@Memphiz
Copy link
Member

commented Sep 27, 2016

what a bitch to track down ... i think this might be broken since the change of GetHomePath or since the switch to cmake build ... (maybe the latter).

… to find it by starting on the executable path instead of the bundle path (which has a ".." in it and we would falsely detect the source tree as valid homepath - instead of the kodi-build dir when building tests with cmake)
@Memphiz

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2016

jenkins build this please and test the shit out of osx

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 27, 2016

shit tested :)

@Memphiz

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2016

Yeah baby :)

@Memphiz Memphiz merged commit f75cc2c into xbmc:master Sep 27, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@Memphiz Memphiz deleted the Memphiz:osx_fixtests branch Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.