Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove home screen info mapping from remote.xml #10585

Merged
merged 1 commit into from Oct 2, 2016

Conversation

@ghost
Copy link

commented Sep 29, 2016

As in Krypton dynamically filled lists support the info action to display the relevant info dialog (e.g. info on a dynamically filled list of movies will show the details of the selected item in DialogVideoInfo.xml) this removes the override in remotes.xml that remaps info to displaying the System Information dialog, so that - by default - pressing info on a remote on the home screen displays the relevant media information dialog.

@mention-bot

This comment has been minimized.

Copy link

commented Sep 29, 2016

@Ignoble61, thank you for improving Kodi! According to the last 5 commits, we found the potential reviewers: @ronie, @ksooo and @NedScott. Final approval needs to be given by the component maintainer.

@NedScott

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2016

Seems logical to me.

@MartijnKaijser MartijnKaijser merged commit 25601d3 into xbmc:master Oct 2, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta3 milestone Oct 2, 2016
@un1versal

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2016

This PR removed the possibility to access system information screen (screen below) from home menu directly, now its only possible by many navigational clicks.

screenshot023

reverting this PR restores that desired functionality.

A perfect example of fixing what isnt broken. now is indeed broken @Ignoble61

and FYI if you pressed info over media always bought up the media info dialog.

@ghost

This comment has been minimized.

Copy link
Author

commented Nov 15, 2016

You read the OP as to what this PR fixed that was broken, right? Anyway, not something I feel strongly enough about to argue over, I'll happily go back to my custom keymap and not try to contribute again :)

@hudokkow

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

No need for you guys to get aggravated. If it's wrong it will be fixed.

@ace20022

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

@Ignoble61 keep in mind that @un1versal isn't a team member. Ofc you are welcomed to contribute in the future. And @un1versal stop bashing!

@phil65

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

It´s just noise, @Ignoble61 :) Dont pay attention to it, all fine with this PR.

@ghost

This comment has been minimized.

Copy link
Author

commented Nov 15, 2016

Sorry, I badly wrote that and it came across more negatively than the humorous tone I had in my head (it's amazing how often I miss that tone!) I'm very happy to attempt to contribute again if ever I find something small like this that I can do

@un1versal

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2016

And @un1versal stop bashing!

You all will get your wish and I doubt I will be alive by 2017, in fact I doubt Iwill see the new years, so good ridens. One less undesired

@da-anda

This comment has been minimized.

Copy link
Member

commented Nov 15, 2016

If one is pressing "info" on a media item on home screen, then the info dialog should appear, just like in media windows. So consistency is desired here. System info otoh is not anything that's frequently used by regular users, so having to do a couple extra clicks (or a custom keymap) seems fine to me.

@un1versal omg, that's sad news. Get well, if possible, and thanks much for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.