Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videoplayer] refactor/cosmetics GetExternalStreamDetailsFromFilename #10587

Merged
merged 1 commit into from Sep 30, 2016

Conversation

@ace20022
Copy link
Member

commented Sep 29, 2016

No description provided.

- return an ExternalStreamInfo object instead of passing it by ref.
- rename params
- add doxygen
@ace20022

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2016

@FernetMenta for review. the second commit seems somewhat lost, but it bugged me for a while now.

@ace20022

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2016

nvm I'll move the second commit to another pr.

@ace20022 ace20022 force-pushed the ace20022:ref_stream_det branch from aa5e01e to 3b3e364 Sep 29, 2016
@FernetMenta

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

+1

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

jenkins build this please

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

je jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 5b48785 into xbmc:master Sep 30, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@ace20022 ace20022 deleted the ace20022:ref_stream_det branch Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.