Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xbmc][fix] Fix issue where yes/no dialog would show blank buttons #10603

Merged
merged 1 commit into from Oct 1, 2016

Conversation

@Paxxi
Copy link
Member

commented Oct 1, 2016

Default values given to ShowYesNoDialog was wrong and caused the null check to think they contained valid values.

Description

Add a default constructor to CVariant to allow instantiating a null CVariant

Motivation and Context

Solves a bug seen when downloading Metropolis skin(likely any skin) and being asked to install the Skin Helper Addon

How Has This Been Tested?

Run time tested

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
    Setting default values to empty strings is not very smart
    when checking for a null variant. It's not null and we
    end up displaying empty strings instead of yes/no
Setting default values to empty strings is not very smart
when checking for a null variant. It's not null and we
end up displaying empty strings instead of yes/no
@Paxxi

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2016

jenkins build this please

@ronie

This comment has been minimized.

Copy link
Member

commented Oct 1, 2016

thx. came across this issue a few times as well.

@MartijnKaijser MartijnKaijser merged commit 704d011 into xbmc:master Oct 1, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
asavah added a commit to asavah/xbmc that referenced this pull request Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.