Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTB on OSX: fix flickering video caused by buffer overwrite #10615

Merged
merged 2 commits into from Oct 4, 2016

Conversation

FernetMenta
Copy link
Contributor

see title. This applies the same concept we already have for vdpau and vaapi.

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Video labels Oct 4, 2016
@FernetMenta FernetMenta added this to the Krypton 17.0-beta3 milestone Oct 4, 2016
@mention-bot
Copy link

@FernetMenta, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afedchin, @davilla and @Memphiz to be potential reviewers.

@FernetMenta
Copy link
Contributor Author

@Memphiz I think iOS has the same issue. There you could use the standard functions glFenceSync that are available for GLES.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@MartijnKaijser
Copy link
Member

jenkins build this please (github died for awhile)

@MartijnKaijser
Copy link
Member

ignore the win32 fail

@Memphiz
Copy link
Member

Memphiz commented Oct 4, 2016

Nice - great work - thx - so thats the fix for the stuttering issue?

@FernetMenta
Copy link
Contributor Author

@Memphiz "stuttering" is not the right term if you mean this case: http://forum.kodi.tv/showthread.php?tid=281517

"choppy" is better suited here. But since there a always multiple definitions out there, I requested a video for better diagnosis :)

jenkins build this please

@MrMC
Copy link

MrMC commented Oct 4, 2016

might want to check the ref count on m_vtbbuf, vda/vtb will not re-use it if greater than one.

@popcornmix
Copy link
Member

glFenceSync is GLES3 only, not GLES2:
https://www.khronos.org/opengles/sdk/docs/man3/html/glFenceSync.xhtml

@FernetMenta
Copy link
Contributor Author

might want to check the ref count on m_vtbbuf, vda/vtb will not re-use it if greater than one.

that is not the problem here

@FernetMenta FernetMenta merged commit df45f18 into xbmc:master Oct 4, 2016
@FernetMenta FernetMenta deleted the vtb branch October 4, 2016 15:01
@MrMC
Copy link

MrMC commented Oct 4, 2016

ok mr.expert :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants