New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTB on OSX: fix flickering video caused by buffer overwrite #10615
Conversation
@FernetMenta, thanks for your PR! By analyzing the history of the files in this pull request, we identified @afedchin, @davilla and @Memphiz to be potential reviewers. |
@Memphiz I think iOS has the same issue. There you could use the standard functions glFenceSync that are available for GLES. |
jenkins build this please |
jenkins build this please (github died for awhile) |
ignore the win32 fail |
Nice - great work - thx - so thats the fix for the stuttering issue? |
@Memphiz "stuttering" is not the right term if you mean this case: http://forum.kodi.tv/showthread.php?tid=281517 "choppy" is better suited here. But since there a always multiple definitions out there, I requested a video for better diagnosis :) jenkins build this please |
might want to check the ref count on m_vtbbuf, vda/vtb will not re-use it if greater than one. |
glFenceSync is GLES3 only, not GLES2: |
that is not the problem here |
ok mr.expert :) |
see title. This applies the same concept we already have for vdpau and vaapi.