Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album is compilation and last played rules and fix missing sort orders in smart playlists #10618

Merged
merged 3 commits into from Oct 12, 2016

Conversation

Projects
None yet
3 participants
@DaveTBlake
Copy link
Member

commented Oct 4, 2016

Fix missing rules and sort orders.
The compilation flag had been omitted as a rule for albums playlists, adding it means that users can now create playlists and filter type custom nodes for compilations (or exclude them).

Similarly with Last Played date, including it means that users can create their own variations of the recently played albums node without core code changes.

While doing that found that some of the sort orders were missing too, causing the display to ignore the order defined in the playlist.

A good test would be to create a playlist of recently played compliations.

@mention-bot

This comment has been minimized.

Copy link

commented Oct 4, 2016

@DaveTBlake, thanks for your PR! By analyzing the history of the files in this pull request, we identified @phate89, @Montellese and @notspiff to be potential reviewers.

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2016

Recently played compilation albums playlist

<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<smartplaylist type="albums">
    <name>Last Played Compilations</name>
    <match>all</match>
    <rule field="compilation" operator="true" />
    <limit>25</limit>
    <order direction="descending">lastplayed</order>
</smartplaylist>

@zag2me would you like a build to test?

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2016

jenkins build this please

@DaveTBlake DaveTBlake added this to the Krypton 17.0-beta4 milestone Oct 8, 2016

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2016

Test build available here http://mirrors.kodi.tv/test-builds/win32/KodiSetup-20161008-ef6f476-MusicTest02.exe (It also includes fix to songs node for MariaDB PR10657)

@jjd-uk

This comment has been minimized.

Copy link
Member

commented Oct 9, 2016

The example playlist you've given doesn't seen to work, I assuming that the most recently played album should appear at the top? if so then that isn't happening.

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2016

Thanks for looking at this @jjd-uk, it is always good to get someone else to try out changes.

That example playlist will find the most recent 25 compilation albums (assuming that you have that many) and show the most recently played at the top. But the order you see them displayed can also depend on the sort you apply to that view - you can change it from the side blade. And if you have not played the compilation albums, then the date is null and they revert to sorting by title (and no date is shown). I guess that is what you are seeing, but do let me know either way (with screen shot if not).

@jjd-uk

This comment has been minimized.

Copy link
Member

commented Oct 11, 2016

Now I know how Last Played is supposed to behave all now appears to be fine to me, so a +1 from me to get this pulled in. I must say the default "Last Played" behaviour of having play all the way through every track on the album is not very unintuitive to me.

@DaveTBlake DaveTBlake merged commit 5c20021 into xbmc:master Oct 12, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:RuleCompilation branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.