Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] make onclick override conditional. Fallback to default actio… #10663

Merged
merged 1 commit into from Oct 10, 2016

Conversation

@BigNoid
Copy link
Member

commented Oct 9, 2016

…n if no condition is met.

In #8178 override on clicks were introduced for dynamic content lists. Problem is that once you add an onclick tag to a container it will always try to execute that onclick even if you put a condition to it. This fixes that problem.
Thx to @phil65 for the hint.

Imo this is a fix as previous behaviour was wrong but no problem to lift it to v18 too if anyone objects.

@ronie

This comment has been minimized.

Copy link
Member

commented Oct 9, 2016

yup, krypton material imo

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta4 milestone Oct 9, 2016

@phil65

This comment has been minimized.

Copy link
Member

commented Oct 9, 2016

jenkins build this please.

@BigNoid BigNoid merged commit 04d0abb into xbmc:master Oct 10, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details

@BigNoid BigNoid deleted the BigNoid:conditional_onclick_override branch Nov 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.