Skip to content

Add 'Play the next video automatically' option #1069

Merged
1 commit merged into from Oct 7, 2012

3 participants

@ScudLee
ScudLee commented Jun 13, 2012

As the title says, this adds a 'Play the next video automatically' option to the video playback settings, to match the one for music.

It also hides the 'Play from here' context menu button when this is option is set, since it's redundant.

@NedScott

For the sake of simplifying our settings, would it be possible to have this in

Settings -> Videos -> File lists -> "Default select action"

?

@ScudLee
ScudLee commented Jun 25, 2012

My rationale for having it as a separate setting was so that the default select action could still be applied to the first item selected. The current behavior of the context menu "Play from here" is to ignore any resume point and always start from the beginning, and I've seen at least one person complain about that. While it's probably trivial to get the resume point, you'd likely then have someone complaining about it always resuming, or, if presented with the resume/play from the beginning option, asking whether there was a way to just always resume. There's probably even weirdos out there who use "Show information" as their select action but who still want continuous play. You'd never win.

So short of adding a whole bunch of different "Play from here" options (which seems silly to me), it just seemed simpler to have the two settings act independently.

@ScudLee
ScudLee commented Jul 13, 2012

Rebased after a85cf75.

@ybart
ybart commented Aug 16, 2012

Hope this will soon be merged in XBMC master branch ! Thanks for this feature.

@ScudLee
ScudLee commented Sep 6, 2012

Rebased after 4e9cb43

@NedScott
NedScott commented Oct 1, 2012

Would really like to see this get added for Frodo. I will see if I can find which XBMC dev to ping about this.

@ScudLee
ScudLee commented Oct 1, 2012

Cool.

I've considered instead of just removing the 'Play from here' option when this is setting is on, replacing it with a 'Play only this' option, so that either way you'd have access to the alternate behavior. Do you think it's worth adding, or should I just keep it simple?

@ghost
ghost commented Oct 7, 2012

i like that ^. also you should use the viewstate for this, not do it directly in the window.

@ScudLee
ScudLee commented Oct 7, 2012

Okay, think I got your meaning (I hope).

That way does also make it easier to allow for more finesse in deciding when autoplay should be used... Not that I've bothered here - it's still either on everywhere or off everywhere, but the possibility does exist.

@ghost ghost merged commit 489d206 into xbmc:master Oct 7, 2012
@ghost
ghost commented Oct 15, 2012

please, do NOT post shit like this on github! you are spamming over 100 people with that useless comment (and so am i with this...) keep it on the forums!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.