Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xbmc][Fix] Guard against double free by setting our deleted values to nullptr #10745

Merged
merged 1 commit into from Oct 22, 2016

Conversation

@Paxxi
Copy link
Member

commented Oct 22, 2016

Issue found through crash reports
HEAP_CORRUPTION_ACTIONABLE_LFHSegmentDoubleFree_DOUBLE_FREE_DETOURS_c0000374_kodi.exe!CVariant::cleanup

Description

Motivation and Context

Crashes reported through Windows Store and Google Play, reasonable to assume it's on all platforms

How Has This Been Tested?

Not at all, don't know how to reproduce crash

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
Issue found through crash reports
HEAP_CORRUPTION_ACTIONABLE_LFHSegmentDoubleFree_DOUBLE_FREE_DETOURS_c0000374_kodi.exe!CVariant::cleanup
@Paxxi

This comment has been minimized.

Copy link
Member Author

commented Oct 22, 2016

jenkins build this please

@Paxxi Paxxi merged commit cf08208 into xbmc:master Oct 22, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@Paxxi Paxxi deleted the Paxxi:cvariant branch Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.