Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [droid;apps] handles missing res icon #10777

Merged
merged 1 commit into from Oct 26, 2016

Conversation

@koying
Copy link
Contributor

commented Oct 26, 2016

Description

Properly handle the case when there is no icon for an app

Motivation and Context

Multiple crashes reported on Store

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

Confirm it doesn't have regressions navigating through Android apps
Jenkins build this please

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

Jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 336442b into xbmc:master Oct 26, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.