Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdvd/Makefile: cross-compile, allow to specify the ar command #10782

Merged
merged 1 commit into from Oct 27, 2016

Conversation

@tgurr
Copy link
Contributor

commented Oct 26, 2016

This commit fixes a build issue on cross environments where the ar command may be prefixed with e.g. the host triplet, like x86_64-pc-linux-gnu-ar and results in a build failure not finding the ar command.

How Has This Been Tested?

Building kodi-17.0_beta4 locally with the changes applied.

Types of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
Allow specifying the AR variable to fix build in cross environments
that have the ar command prefixed with e.g. the host triplet, like
x86_64-pc-linux-gnu-ar.
@wsnipex

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

Thanks, the fix is ok, but we're in the process of deprecating autotools, so you should probably check if a similar fix is needed for the cmake build system in project/cmake.

@tgurr

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2016

I came across the error when packaging Kodi 17.0 beta4 (autotools based build) to see if there are any issues which would be nice to have fixed before the final is released. I'm afraid I can't promise that I'll have time to look into the CMake based build any time soon.

@wsnipex

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

ok
jenkins build this please

@koenkooi

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2016

Cmake tends to be less susceptible to issues like this if you're using a toolchain file.

@wsnipex wsnipex merged commit b877fe4 into xbmc:master Oct 27, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta5 milestone Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.