fix fetching playcount for plugin listings with content set #1083

Merged
merged 1 commit into from Jun 20, 2012

Conversation

Projects
None yet
2 participants
Member

pieh commented Jun 17, 2012

This fixes problem described in http://forum.xbmc.org/showthread.php?tid=134027

Current routine to fetch additional info for videos is a bit flawed: it assume that if items have content set - then we don't have to fetch additional metadata/playcount. This doesn't work well for plugins (which might set items content).

I just added additional check to test if items were created from database (which I hope, means that metadata and playcount are already fetched).

Owner

MartijnKaijser commented Jun 17, 2012

Just tested the patch and can confirm it works.
Would it be valid to also back port this fix to Eden .1 release?

Member

pieh commented Jun 18, 2012

updated commit with change
!items.IsPlugin()

@ghost

ghost commented Jun 18, 2012

looks fine.

pieh merged commit ac77611 into xbmc:master Jun 20, 2012

@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request Apr 4, 2014

@tru tru Added CPlexServer::GetLocalConnection() and tests.
Part of #1083
edfd928

@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request Apr 4, 2014

@tru tru When constructing the photo transcoder URL we need to to check server…
… port.

Before it was hardcoded to use 32400, we now check if we have a local
connection for the server and use that to lookup the port. We can’t
just use any activeConnection because it could be a port that is mapped
via UPnP and will not correspond to the port the server is actually
listening to.

Related to #1083.
0f973f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment