Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] access violation in CFFmpegImage::Initialize #10842

Merged
merged 1 commit into from Nov 2, 2016

Conversation

@Rechi
Copy link
Member

commented Nov 2, 2016

Description

Check number of AVStreams is at least one before accessing the first AVStream.

Motivation and Context

Kodi was crashing if I opened a specific directory.

How Has This Been Tested?

Runtime tested

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@FernetMenta

This comment has been minimized.

Copy link
Member

commented Nov 2, 2016

thanks,
jenkins build and merge

@fritsch

This comment has been minimized.

Copy link
Member

commented Nov 2, 2016

Could you upload that specific sample? Might be sth for upstream, too.

@MartijnKaijser MartijnKaijser merged commit 78d566b into xbmc:master Nov 2, 2016
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
default You are a failure. Fix the code and try again......
Details
jenkins4kodi Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Rechi

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2016

@fritsch I think it's not a direct ffmpeg problem. CBaseTexture::LoadFromFileInternal (https://github.com/xbmc/xbmc/blob/master/xbmc/guilib/Texture.cpp#L230) gets called with a directory as texturePath for the faulty directory. Normally it is called with file paths.

@Rechi Rechi deleted the Rechi:fixFFmpegImage branch Nov 2, 2016
@fritsch

This comment has been minimized.

Copy link
Member

commented Nov 2, 2016

Then we should also fix the root cause but this code here is never the less correct. Thx again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.