Join GitHub today
[binary-addons] Rename DEPENDS_PATH to ADDON_DEPENDS_PATH #10865
A variable called DEPENDS_PATH is used twice in the build system:
This change renames the variable for binary-addons to ADDON_DEPENDS_PATH. Alternative would be to rename the variable in the toolchain file. While this would be less effort, I think it's cleaner if DEPENDS_PATH is used for core depends, not addon depends.
Motivation and Context
This can cause very hard to debug issues. I've ran into it while trying to compile a binary addon with our normal Toolchain file. The toolchain file accidentally tells the addon build system to compile addon depends into the system depends and even worse: to pick up depends from there.
How Has This Been Tested?
Locally on Linux and osx.
Screenshots (if appropriate):
Types of change
DEPENDS_PATH is used twice in the code build system it's set to the system depends path (via toolchain file). In the addon system it's used to point to the place where addon dependencies should be built. This change renames the variable for binary-addons to ADDON_DEPENDS_PATH. The toolchain file can then be used for local addon builds.
Working as expected, except for the usual suspects failing.
The only add-on I could find using DEPENDS_PATH on my (somewhat outdated) add-ons build env is screensavers.rsxs.
jenkins retroplayer-17beta5 build with this PR + missing bits: http://jenkins.kodi.tv/view/Windows/job/WIN-32/10567/