Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Move eject drive and eject disk to new contextmenu system #10890
Marvel your eyes, as your now able to eject your disks and drives right from your homescreen
Motivation and Context
No ejection from the homescreen
How Has This Been Tested?
Only tested eject disk, as I have no drive to eject in my reach.
Types of change
2 similar comments
Dec 12, 2016
Nobody had anything to say for 1 and a half month. I don't exactly call this hurry.
Master is open for pre alpha again and I feel like having PRs to be perfect and not giving people the doubt to deliver follow up PRs is also hurting us more then helping. Just my 2 cent :)
@Razzeee just discovered that this PR introduces another regression: "Eject" is no longer available in the context menu in Kodi's file manager. Before this, PR, for example, "Eject" appeared in the context menu of a mounted USB stick. Reason is that file manager does not use the new context menu system, but CGUIDialogContextMenu, where this PR removes the items in question from. :-/