Skip to content

texturepacker: crosscompile fixes #1090

Closed
wants to merge 1 commit into from

5 participants

@sraue
Team Kodi member
sraue commented Jun 19, 2012

this fixes:

  • libsquish-native.so will be built even if TextuePacker is disabled
  • libsquish-native.so will be built for target
  • native TextuePacker will not be built if TexturePacker is enabled and we cross-compile

This change:

  • adds '--with-texturepacker-root=" to configure script to configure the location of the host library and include dir to search if native T exturePacker should be build. If not configured it falls back to $prefix (the default location for most host tools). This location can be still hardcoded in configure.in with 'use_texturepacker_root='.
  • if we enable TexturePacker building and we crosscompile we force the native building of TexturePacker.
  • using $HOST_CXX for building native TexturePacker and native libsquish and fall back to 'g++'.
  • using $HOST_CXXFLAGS and $HOST_LIBS for building native TexturePacker and native libsquish if configured.
@sraue sraue texturepacker: crosscompile fixes
this fixes:
- libsquish-native.so will be built even if TextuePacker is disabled
- libsquish-native.so will be built for target
- native TextuePacker will not be built if TexturePacker is enabled and we cross-compile

This change:
- adds '--with-texturepacker-root=" to configure script to configure the location of the host library and include dir to search if native T
exturePacker should be build. If not configured it falls back to $prefix (the default location for most host tools). This location can be still hardcoded in configure.in with 'use_texturepacker_root='.
- if we enable TexturePacker building and we crosscompile we force the native building of TexturePacker.
- using $HOST_CXX for building native TexturePacker and native libsquish and fall back to 'g++'.
- using $HOST_CXXFLAGS and $HOST_LIBS for building native TexturePacker and native libsquish if configured.
06256de
@theuni
Team Kodi member
theuni commented Jun 19, 2012

Much of this could be helpful for other things, not just texturepacker (anything the builder needs built). Why not make it a --with-build-prefix?

Use of HOST_* is very confusing, as HOST typically means the cross target. I suggest switching to CC_FOR_BUILD and CXX_FOR_BUILD, BUILD_CFLAGS, BUILD_CXXFLAGS as these are common in other cross builds. Same goes for other usage of HOST*

@theuni
Team Kodi member

If libsquish-native.so needs to be built before texturepacker, please make texturepacker depend on it in the main make instead.

@davilla
davilla commented Jun 21, 2012

+1 on theuni's comments.

@sraue
Team Kodi member
sraue commented Jun 21, 2012

i will work this out the next days, that was my plan too, but i was not sure if it would be accepted

@da-anda
Team Kodi member
da-anda commented Sep 2, 2013

@sraue can this PR get some love? The "next days" where long ago ;)

@sraue sraue referenced this pull request Sep 3, 2013
Merged

Texturepacker rework #3190

@MartijnKaijser
Team Kodi member

see #3190

@sraue sraue deleted the OpenELEC:texturepacker branch Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.