Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Settings: change label and description to reflect that 'TV' is actually 'PVR & Live TV.' #10911

Merged
merged 1 commit into from Nov 12, 2016

Conversation

@ksooo
Copy link
Member

commented Nov 11, 2016

We discussed this on slack some time ago, but somehow it got (partly) lost.

screenshot002
screenshot003

@jjd-uk is this okay?

@jjd-uk

This comment has been minimized.

Copy link
Member

commented Nov 11, 2016

While I agree it should be changed from "TV" I tried to ensure the category labels weren't too long so not 100% on this change. I would be tempted to just call it "PVR" as in the UK at least PVR's have been around 15 years, and is widely understood by nearly everyone here. Is PVR not so widely understood in other countries? or is it more to do with the case that some add-on's don't facilitate recording?

Note this is not an objection so feel free to merge as is, since it's better than what we currently have.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2016

or is it more to do with the case that some add-on's don't facilitate recording?

yes indeed.

@jjd-uk

This comment has been minimized.

Copy link
Member

commented Nov 11, 2016

Then ok from my end

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2016

Then ok from my end

thanks. if nobody objects i will merge this tomorrow.

@ksooo ksooo merged commit ae37dd6 into xbmc:master Nov 12, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ksooo ksooo deleted the ksooo:pvr-settings-label branch Nov 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.