Skip to content
This repository

Don't correct episode numbering from scraper #1093

Merged
1 commit merged into from almost 2 years ago

2 participants

ScudLee jmarshallnz
ScudLee

This removes the code that corrects the episode numbers retrieved from a scraper so that the lowest episode number becomes episode 1.

Does this code have any legitimate use? It just seems to cause the occasional confusion:
http://forum.xbmc.org/showthread.php?tid=128732
http://forum.xbmc.org/showthread.php?tid=132441
http://forum.xbmc.org/showthread.php?tid=134266

jmarshallnz
Owner

@cptspiff Where does this come from?

Deleted user
ghost commented June 23, 2012

The content you are editing has changed. Reload the page and try again.

It is a mighty old leftoter that was there to facilitate an old tv.com scraper. For some stupid reason they used a flat episode number at some point and this code was there to compensate. Nuke at will

Sending Request…

Attach images by dragging & dropping or selecting them. Octocat-spinner-32 Uploading your images… Unfortunately, we don't support that file type. Try again with a PNG, GIF, or JPG. Yowza, that's a big file. Try again with an image file smaller than 10MB. This browser doesn't support image attachments. We recommend updating to the latest Internet Explorer, Google Chrome, or Firefox. Something went really wrong, and we can't process that image. Try again.

Deleted user ghost merged commit d3cc12d into from July 03, 2012
Deleted user ghost closed this July 03, 2012
Tobias Hieta tru referenced this pull request from a commit in RasPlex/plex-home-theatre April 03, 2014
Tobias Hieta Send filter and sort arguments to the PlayQueue
Fixes #1093
84980f0
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jun 19, 2012
ScudLee Don't correct episode numbering from scraper 6f04eda
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 0 additions and 19 deletions. Show diff stats Hide diff stats

  1. 19  xbmc/addons/Scraper.cpp
19  xbmc/addons/Scraper.cpp
@@ -832,25 +832,6 @@ EPISODELIST CScraper::GetEpisodeList(XFILE::CCurlFile &fcurl, const CScraperUrl
832 832
     }
833 833
   }
834 834
 
835  
-  // find minimum in each season
836  
-  map<int, int> mpMin;
837  
-  for (EPISODELIST::const_iterator i = vcep.begin(); i != vcep.end(); ++i)
838  
-  {
839  
-    map<int, int>::iterator iMin = mpMin.find(i->key.first);
840  
-    if (iMin == mpMin.end())
841  
-      mpMin.insert(i->key);
842  
-    else if (i->key.second < iMin->second)
843  
-      iMin->second = i->key.second;
844  
-  }
845  
-
846  
-  // correct episode numbers
847  
-  for (EPISODELIST::iterator i = vcep.begin(); i != vcep.end(); ++i)
848  
-  {
849  
-    i->key.second -= mpMin[i->key.first];
850  
-    if (mpMin[i->key.first] > 0)
851  
-      ++i->key.second;
852  
-  }
853  
-
854 835
   return vcep;
855 836
 }
856 837
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.