Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller dialog fixes and code improvements #10932

Merged
merged 5 commits into from Nov 19, 2016

Conversation

@garbear
Copy link
Member

commented Nov 15, 2016

This PR fixes two bugs in the controller dialog, one is a bug that was introduced by #10910, and one is a preexisting bug that was uncovered by #10910.

Also included are logging and code style improvements.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Broken out from #10630

@garbear garbear referenced this pull request Nov 16, 2016
18 of 26 tasks complete
@garbear

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2016

Updated with an additional fix for a bug in #10630: The right analog stick would lowers the volume immediately after mapping is finished in the controller dialog.

@a1rwulf

This comment has been minimized.

Copy link
Member

commented Nov 17, 2016

I definitely don't know a lot about this code, but it looks good to me.

Defect was:

*** CID 152106:  Uninitialized members  (UNINIT_CTOR)
GUIConfigurationWizard.cpp: 41 in GAME::CGUIConfigurationWizard::CGUIConfigurationWizard()()
35     #define SKIPPING_DETECTION_MS  200
36
37     CGUIConfigurationWizard::CGUIConfigurationWizard() :
38       CThread("GUIConfigurationWizard")
39     {
40       InitializeState();
>>>     CID 152106:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_callback" is not initialized in this constructor nor in any functions that it calls.
41     }
42
43     void CGUIConfigurationWizard::InitializeState(void)
44     {
45       m_currentButton = nullptr;
46       m_currentDirection = JOYSTICK::ANALOG_STICK_DIRECTION::UNKNOWN;
@garbear garbear force-pushed the garbear:controller-dialog branch from ec02528 to 681fb56 Nov 19, 2016
@garbear

This comment has been minimized.

Copy link
Member Author

commented Nov 19, 2016

Added fix for Coverty warning.

jenkins build this please

@garbear garbear merged commit 0d6ba1f into xbmc:master Nov 19, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@garbear garbear deleted the garbear:controller-dialog branch Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.