Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curl] cleanup multi handle in proper order #10947

Merged
merged 1 commit into from Nov 20, 2016

Conversation

@Kwiboo
Copy link
Contributor

commented Nov 16, 2016

Description

Changes cleaning up order of curl multi/easy handles

Motivation and Context

From https://curl.haxx.se/libcurl/c/curl_multi_cleanup.html
1 - curl_multi_remove_handle before any easy handles are cleaned up
2 - curl_easy_cleanup can now be called independently since the easy handle is no longer connected to the multi handle
3 - curl_multi_cleanup should be called when all easy handles are removed

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
[curl] cleanup multi handle in proper order
From https://curl.haxx.se/libcurl/c/curl_multi_cleanup.html
1 - curl_multi_remove_handle before any easy handles are cleaned up
2 - curl_easy_cleanup can now be called independently since the easy handle is no longer connected to the multi handle
3 - curl_multi_cleanup should be called when all easy handles are removed
@hudokkow

This comment has been minimized.

Copy link
Member

commented Nov 16, 2016

Thanks for your contribution.
Not really sure who to ping. @Paxxi, @Montellese, @notspiff

@hudokkow hudokkow added the Type: Fix label Nov 16, 2016

@wsnipex

This comment has been minimized.

Copy link
Member

commented Nov 17, 2016

it looks correct, but since this a pretty critical part of the code, this is something for v18

@Paxxi

This comment has been minimized.

Copy link
Member

commented Nov 17, 2016

Thank you for spotting this. This is a fix and I think it should go in right away since we currently do it wrong and probably in undefined behavior territory

@arnova

This comment has been minimized.

Copy link
Member

commented Nov 20, 2016

Yup, but better shove it in ASAP then so we can spot any regressions way before we go final.

@Paxxi Paxxi merged commit 2ca3ff4 into xbmc:master Nov 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kwiboo Kwiboo deleted the Kwiboo:curl branch Nov 20, 2016

@hudokkow hudokkow added this to the Krypton 17.0-beta6 milestone Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.