Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estouchy] update to match the new look of the default skin #10991

Merged
merged 1 commit into from Nov 27, 2016

Conversation

@ronie
Copy link
Member

commented Nov 25, 2016

i've updated estouchy to match the new look of estuary.

@phil65 @HitcherUK @BigNoid for review

@BigNoid

This comment has been minimized.

Copy link
Member

commented Nov 26, 2016

Testing it now on a touch device and it works great so far, just like previous version. One of the new design directions Estuary has taken is to use list overflow to show the user how the panels navigate. I feel this could benefit Estouchy too in the home widgets panels and the panel views in library. Since there are shadows now instead of hardline bars at top/bottom it looks like the rest of the items come out of nowhere, which would also be gone if using list overflow.

@ronie

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2016

correct me if i'm wrong, but wouldn't that break touch (and mouse) support?

the side effect of the code needed to get overflow working in panels,
is that the focused position will be off when using touch/mouse input.

estuary-mouse

@ronie ronie force-pushed the ronie:estouchyv2 branch from d35a134 to 423c7a1 Nov 26, 2016
@BigNoid

This comment has been minimized.

Copy link
Member

commented Nov 26, 2016

Right, good point. We need hitrect for the focused item I think as this offset is already the case in Estuary which is said to have mouse support.
I tried with the offsety tag, but the focusedposition is still off with that (so that tag is pretty much useless :) )

@ronie ronie force-pushed the ronie:estouchyv2 branch from 423c7a1 to 3fb9592 Nov 27, 2016
@ronie ronie force-pushed the ronie:estouchyv2 branch from 3fb9592 to 9a816b2 Nov 27, 2016
@ronie ronie merged commit 0353b33 into xbmc:master Nov 27, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hudokkow hudokkow added this to the Krypton 17.0-beta6 milestone Nov 28, 2016
@ronie ronie deleted the ronie:estouchyv2 branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.