Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fullscreen video: On up/down and no channel info is currently s… #10995

Merged
merged 1 commit into from Nov 27, 2016

Conversation

@ksooo
Copy link
Member

commented Nov 26, 2016

Fullscreen video: On up/down and no channel info is currently shown, display channel info for playing channel, not info for next/prev channel.

This is, how other PVRs behave and was requested in the forum: http://forum.kodi.tv/showthread.php?tid=297623

This change was tested on latest krypton master on macOS.

@Jalle19 objections?

[PVR] Fullscreen video: ON up/down and no channel info is currently s…
…hown, display channel info for playing channel, not info for next/prev channel.
@Glenn-1990

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2016

@ksooo Does this mean that channel up does not switch a channel on the first press?

@Jalle19

This comment has been minimized.

Copy link
Member

commented Nov 27, 2016

If this only happens when "confirm channel switches by pressing OK" is enabled then I guess it's fine. If people want to switch channels by pressing up/down immediately we shouldn't change the behavior for them.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2016

@ksooo Does this mean that channel up does not switch a channel on the first press?

No. This has only effect if "confirm channel switch with OK" is enabled. Then, and only then, first up/down opens the info osd for the playing channel. Without this PR, info osd for next channel is opened. This means, if you want to see see osd for the playing channel, without this PR, you have to do first up, then down.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2016

If this only happens when "confirm channel switches by pressing OK" is enabled then I guess it's fine. If people want to switch channels by pressing up/down immediately we shouldn't change the behavior for them.

all good. behaves exactly like you like it.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2016

jenkins build this please

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2016

@Glenn-1990 btw, channel up/down always switches channels, regardless of "confirm channel switch with ok" value. The latter only influences behavior of (cursor) up/down.

@Glenn-1990

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2016

@ksooo seems a valid addition then ;-)

@ksooo ksooo merged commit 0a7da65 into xbmc:master Nov 27, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins4kodi You did a great job. Have a cookie.
Details

@ksooo ksooo deleted the ksooo:pvr-fix-first-channel-info branch Nov 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.