Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbp: Don't close the display here it should be closed by the opener #11006

Merged
merged 1 commit into from Nov 29, 2016

Conversation

@popcornmix
Copy link
Member

commented Nov 28, 2016

Description

Don't close the display here it should be closed by the opener

Motivation and Context

During a normal shutdown, either way is fine as the EGL context has already been shut down and the display will already be closed.
However while debugging the exception in #10971 I found that the cleanup code causes the display to be closed with the EGL context still active.
The firmware doesn't like that and can result in garbage on the display.

How Has This Been Tested?

In last week of Milhouse builds.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@popcornmix

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2016

jenkins build this please

@popcornmix popcornmix merged commit 5c7c16d into xbmc:master Nov 29, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@popcornmix popcornmix deleted the popcornmix:displayclose branch Nov 29, 2016
@hudokkow hudokkow added this to the Krypton 17.0-beta6 milestone Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.