Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quell some warnings #11010

Merged
merged 10 commits into from Nov 30, 2016

Conversation

Projects
None yet
3 participants
@notspiff
Copy link
Contributor

commented Nov 29, 2016

These are no-brainer cherry-picks from #10981

@hudokkow

This comment has been minimized.

Copy link
Member

commented Nov 29, 2016

Thx! jenkins build this with addons please

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2016

hmm, i forgot to rebase or something just landed that conflicts. will do after jenkins run finishes.

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2016

done.

@notspiff notspiff force-pushed the notspiff:quell_them_warnings branch from 47c0316 to 5d06907 Nov 29, 2016

@hudokkow

This comment has been minimized.

Copy link
Member

commented Nov 29, 2016

jenkins build this with addons please

@hudokkow hudokkow added v18 Leia and removed v17 Krypton labels Nov 30, 2016

@hudokkow

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

jenkins is happy. Backport worthy?

@FernetMenta, since you raised some concerns in #10981, are you OK with this? It barely touches VP code.

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

all good

@hudokkow hudokkow added this to the L 18.0-alpha1 milestone Nov 30, 2016

@hudokkow

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

Thx both!

@hudokkow hudokkow merged commit 9dd0a07 into xbmc:master Nov 30, 2016

2 of 4 checks passed

default You are a failure. Fix the code and try again......
Details
jenkins4kodi Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notspiff notspiff deleted the notspiff:quell_them_warnings branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.