Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix TexturePacker installation directory #11144

Merged
merged 1 commit into from Dec 16, 2016

Conversation

@garbear
Copy link
Member

commented Dec 11, 2016

This fixes a problem I hit when running make install on a depends-based build. Error was:

CMake Error at cmake_install.cmake:15813 (file):
  file INSTALL cannot find
  "/home/garrett/workspace/kodi/build/build/texturepacker/TexturePacker".


Makefile:61: recipe for target 'install' failed
make: *** [install] Error 1

thanks to fetzerch

@fetzerch

This comment has been minimized.

Copy link
Member

commented Dec 11, 2016

Just for reference, the issue was when doing a depends based build because texture packer is then not compiled as part of Kodi.

@hudokkow

This comment has been minimized.

Copy link
Member

commented Dec 11, 2016

You really need to start using labels on your PRs... ;)
WITH_TEXTUREPACKER sounds weird. HAVE_, HAS_? Something for another PR.

jenkins build this please

@garbear

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2016

jenkins build this please

@garbear

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2016

is there a reason why jenkins isn't building this?

@hudokkow

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

Don't know but I had the same problem with another PR a couple of days ago and had to manually build it.
http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-PR-Manually/245/

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

Jenkins build this please

@garbear

This comment has been minimized.

Copy link
Member Author

commented Dec 15, 2016

failure looks unrelated. ok to merge or should we try again?

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Dec 15, 2016

Jenkins build this please

@hudokkow

This comment has been minimized.

Copy link
Member

commented Dec 15, 2016

wtf, same error that occurred on #10429

Droids gone crazy...

find: ‘/home/jenkins/workspace/Android-X86/build/install/lib/kodi/addons’: No such file or directory
Makefile:129: recipe for target 'libs' failed
make[4]: *** [libs] Error 1

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2016

stefansaraev@d7f4652 should fix android packaging.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2016

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 302baa5 into xbmc:master Dec 16, 2016

2 of 3 checks passed

jenkins4kodi I've found some spare time so building this now
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hudokkow hudokkow added this to the L 18.0-alpha1 milestone Dec 17, 2016

@garbear garbear deleted the garbear:fix-texturepacker-install branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.