Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adsp] bye, bye libKODI_adsp.cpp #11155

Merged
merged 2 commits into from Dec 13, 2016

Conversation

@AlwinEsch
Copy link
Member

commented Dec 13, 2016

Remove the use of shared add-on library for adsp add-ons.
Reopen from #10414 (due to jenkins problem with git revision)

Description

The lib is no more used on add-on. It can be added without changes on add-ons, they need only a recompile.

Motivation and Context

Cleanup binary add-ons

How Has This Been Tested?

Has tested several ADSP add-ons with normal operation.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@AlwinEsch

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2016

jenkins build this with addons please

@AlwinEsch AlwinEsch merged commit 571be50 into xbmc:master Dec 13, 2016

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
default You are a failure. Fix the code and try again......
Details
jenkins4kodi Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@AlwinEsch AlwinEsch deleted the AlwinEsch:remove-shared-addon-lib-adsp-2 branch Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.