Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent failure when game add-on can't be installed #11163

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@garbear
Copy link
Member

commented Dec 13, 2016

On the latest Milhouse builds, game add-ons can't be installed because game.libretro (a dependency) isn't in the libreelec repo. Instead of failing silently, this adds an error dialog.

Screenshots

error dialog

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

ping @tamland
This seems like something we should already have from normal add-ons and i don't like duplication

@tamland

This comment has been minimized.

Copy link
Member

commented Dec 20, 2016

we already have that. and im assuming the commented out code above should be commented in, removing this custom game 'dialog' entirely.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2016

what commented-out code?

@tamland

This comment has been minimized.

Copy link
Member

commented Dec 21, 2016

the one in GUIDialogSelectGameClient.cpp that says 'todo Switch to add-on browser when more emulators have icons'

@garbear garbear referenced this pull request Feb 2, 2017

Open

RetroPlayer Leia 18.0 issues #80

32 of 70 tasks complete
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

Still needed?

@garbear

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

Yea, this is still an issue. The PR stalled because CGUIDialogSelectGameClient needs to be removed, but we can't do this until we can get the game client from a game database.

However, seeing as we don't have a game database, I recommend we merge this to fix the silent error until a game database is ready.

@garbear garbear force-pushed the garbear:notify-failure branch from 1d055dd to cd67973 Jul 22, 2017

@garbear garbear force-pushed the garbear:notify-failure branch from cd67973 to 2047228 Jul 27, 2017

@garbear garbear merged commit c4a7637 into xbmc:master Aug 1, 2017

1 check passed

default You're awesome. Have a cookie
Details

@garbear garbear deleted the garbear:notify-failure branch Aug 1, 2017

@Rechi Rechi added the v18 Leia label Aug 1, 2017

@Rechi Rechi added this to the L 18.0-alpha1 milestone Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.