Fix silent failure when game add-on can't be installed

[garbear]

On the latest Milhouse builds, game add-ons can't be installed because game.libretro (a dependency) isn't in the libreelec repo. Instead of failing silently, this adds an error dialog.

Screenshots

Types of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[MartijnKaijser]

ping @tamland
This seems like something we should already have from normal add-ons and i don't like duplication

[tamland]

we already have that. and im assuming the commented out code above should be commented in, removing this custom game 'dialog' entirely.

[garbear]

what commented-out code?

[tamland]

the one in GUIDialogSelectGameClient.cpp that says 'todo Switch to add-on browser when more emulators have icons'

[MartijnKaijser]

Still needed?

[garbear]

Yea, this is still an issue. The PR stalled because CGUIDialogSelectGameClient needs to be removed, but we can't do this until we can get the game client from a game database.

However, seeing as we don't have a game database, I recommend we merge this to fix the silent error until a game database is ready.