Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] implicit referencing for listitem bools / ints #11205

Merged
merged 1 commit into from Dec 29, 2016

Conversation

@phil65
Copy link
Member

commented Dec 18, 2016

some code refactoring + also allow implicit referencing for listitem bools, listitem ints and container bools.

@ronie @xhaggi

@phil65 phil65 force-pushed the phil65:implicit_ref branch 4 times, most recently from b0253c5 to 79ba614 Dec 18, 2016
@ronie

This comment has been minimized.

Copy link
Member

commented Dec 18, 2016

tested & works great :-)
thx!

@phil65 phil65 force-pushed the phil65:implicit_ref branch from 79ba614 to edfaab0 Dec 18, 2016
@phil65 phil65 force-pushed the phil65:implicit_ref branch from edfaab0 to ca13b57 Dec 18, 2016
@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2016

jenkins build this please.

@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2016

stupid jenkins build this please.

@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 25, 2016

jenkins build this please.

1 similar comment
@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2016

jenkins build this please.

@phil65 phil65 merged commit 4f4e3ec into xbmc:master Dec 29, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Dec 29, 2016
@phil65 phil65 deleted the phil65:implicit_ref branch Dec 29, 2016
@ronie

This comment has been minimized.

Copy link
Member

commented Jan 17, 2017

looks like this is causing regression with grouplists...
explicitly referencing a grouplist in a bool now always returns false.

you can test by adding a label in Estuary to SkinSettings.xml and adding this condition:
<visible>Container(610).HasNext</visible>

it works as expected in krypton, but in leia the label never shows up.

@phil65 phil65 referenced this pull request Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.