Prompt for rescan of music #1124

Merged
merged 2 commits into from Jul 9, 2012

Projects

None yet

2 participants

@jmarshallnz
Member

Music needs rescanning so we can generate the new album/song art (plus also ensure we get the compilations correct, though I suspect this needs more work).

This prompts the user and starts a scan.

Discussion is needed as to whether or not we reset the scan trigger (a setting set on db update) when the user starts a scan using this - if the cancel the scan then it's not possible to rescan without removing the source, clearing things out and readding it.

@jmarshallnz
Member

Alternatives would be:

  1. Invalidate all the paths in the db, so that next scan it'll rescan anyway. Problem is if online lookups are done, then any artists/albums not found will be re-checked even though they don't necessarily need to be (slow). (The above scan turns off online lookups).
  2. Add ability to rescan-all to the music library settings - this would take the normal online lookup setting I guess. Not sure of the use - the current "Update Library" automatically rescans tags that have changed, assuming either filesize or filedate of the media has altered. I guess it might be possible to change a tag without these being changed on some filesystems? If we allow this, do we prompt to also look for online content (if the setting is enabled)?
  3. Add ability to rescan a source from the context menu (not sure this makes sense to be honest - XBMC's music library automatically detects if the user changes any tags) - plus, I hate adding stuff to context.
@jmarshallnz jmarshallnz merged commit a42e86b into xbmc:master Jul 9, 2012
@arnova
Member
arnova commented on 3ec411a Jul 15, 2012

I just updated xbmc on my HTPC with one build from today's master but after the rescan of my music database the info manager no longer shows any music thumbs in the now playing window.

Member

Now playing window isn't the infomanager - it's a known issue though (the MusicInfoLoader runs threaded in that case, the thumb loader doesn't run, and the thumb assigning stuff won't work due to not working on a real folder).

Member

I'm willing to look into this but do you have any ideas how to fix this?

Member

First step is running the thumbloader. Problem with that is that you don't want 2 threads running.

Member

Can't we modify the thumbloader to allow non threaded thumb retrieval and have the musicinfoloader use that to take care of the thumb-loading. Basically a non-threaded version of the thumbloader?

Member
Member
Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment