Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake/win32] Don't use system wide installed dependencies #11246

Merged
merged 1 commit into from Jan 7, 2017

Conversation

@fetzerch
Copy link
Member

commented Dec 22, 2016

Don't let cmake detect system wide installed libraries on windows.

Description

Empty PATH (except VS Toolchain/bin) so that CMake won't pick up system wide installed dependencies (such as MySql or Python).

Motivation and Context

I want to bring this up for discussion again, as we now had a few cases where cmake detected system wide installed libs on windows leading into compile errors. Old PR was #10194

How Has This Been Tested?

by @phate89

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Paxxi I know that you didn't like it last time I suggested this. I think it's still better than wasting time to debug weird errors on dev machines.
Ping some more win devs: @afedchin, @AchimTuran

Empty PATH (except VS Toolchain/bin) so that CMake won't pick up system
wide installed dependencies (such as MySql or Python).
@Paxxi

This comment has been minimized.

Copy link
Member

commented Jan 7, 2017

I still think it's ugly but I agree it's needed

@Paxxi Paxxi merged commit d5a07cf into xbmc:master Jan 7, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.