Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] remove two not-implemented infolabels for PVR #11249

Merged
merged 1 commit into from Dec 23, 2016

Conversation

@phil65
Copy link
Member

commented Dec 22, 2016

remove pvr.hastxt and pvr.hasepg since theyre not implemented.
@ksooo I found out that we already have videoplayer.hasteletext and videoplayer.hasepg :)

Also updated wiki already by removing wrong infolabels and adding correct ones.

I changed all define values to avoid gaps because we are looping over that range at some places.

@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 22, 2016

jenkins build this please.

@ksooo
ksooo approved these changes Dec 22, 2016
@ksooo

This comment has been minimized.

Copy link
Member

commented Dec 22, 2016

jenkins build and merge

@ksooo ksooo added this to the L 18.0-alpha1 milestone Dec 22, 2016
/// _boolean_,
/// Returns true when an epg is available.
/// }
/// \table_row3{ <b>`Pvr.HasTxt`</b>,

This comment has been minimized.

Copy link
@AlwinEsch

AlwinEsch Dec 22, 2016

Member

Is this info no more used and working (Seen that Estuary not use it)?

Was thought from me to enable Teletext GUI button on xml only if Teletext is present.

This comment has been minimized.

Copy link
@phil65

phil65 Dec 22, 2016

Author Member

VideoPlayer.HasTeletext seems to be the correct one ;)
Pvr.HasTxt wasnt even implemented.

This comment has been minimized.

Copy link
@AlwinEsch

AlwinEsch Dec 22, 2016

Member

Ups, sorry.

@ksooo

This comment has been minimized.

Copy link
Member

commented Dec 22, 2016

jenkins build this please

@ksooo

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

jebkins Android errors are not related to this PR

@ksooo ksooo merged commit 3795c81 into xbmc:master Dec 23, 2016
2 of 3 checks passed
2 of 3 checks passed
jenkins4kodi You are a failure. Fix the code and try again......
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phil65 phil65 deleted the phil65:pvr_rem_bools branch Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.