Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] add imx support #11288

Merged
merged 2 commits into from Jan 2, 2017
Merged

[cmake] add imx support #11288

merged 2 commits into from Jan 2, 2017

Conversation

@lrusak
Copy link
Contributor

lrusak commented Dec 28, 2016

Description

Add imx support to cmake

This supercedes #10563

I'm not sure if we want to use IMX or IMXVPU

Backport is available here, lrusak@6d60b50

Motivation and Context

So kodi can be built for imx SOC's

How Has This Been Tested?

In LibreELEC

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
@lrusak

This comment has been minimized.

Copy link
Contributor Author

lrusak commented Dec 29, 2016

ping @mk01

ping cmake people @fetzerch @hudokkow

@mk01

This comment has been minimized.

Copy link
Contributor

mk01 commented Dec 29, 2016

@lrusak
looks to be working

Copy link
Member

fetzerch left a comment

One small issue, otherwise looks fine to me. thanks

set(IMX_DEFINITIONS -DHAS_IMXVPU=1 -DLINUX -DEGL_API_FB)
endif()

mark_as_advanced(IMX_INCLUDE_DIR IMX_LIBRARIES IMX_DEFINITIONS)

This comment has been minimized.

Copy link
@fetzerch

fetzerch Dec 30, 2016

Member

mark_as_advanced(IMX_INCLUDE_DIR FSLVPUWRAP_LIBRARY VPU_LIBRARY G2D_LIBRARY)

@lrusak

This comment has been minimized.

Copy link
Contributor Author

lrusak commented Dec 30, 2016

thanks @fetzerch. updated.

Copy link
Member

fetzerch left a comment

looks good, thanks

jenkins build this please

@lrusak lrusak mentioned this pull request Dec 31, 2016
2 of 9 tasks complete
@fetzerch

This comment has been minimized.

Copy link
Member

fetzerch commented Jan 1, 2017

jenkins build this please

@fetzerch fetzerch merged commit 2c4c414 into xbmc:master Jan 2, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.