Player.Property() support #1130

Merged
merged 2 commits into from Jul 7, 2012

Conversation

Projects
None yet
4 participants
Member

jmarshallnz commented Jul 7, 2012

Pretty trivial request for Hitcher.

@Montellese: this reverts part of your hard work, but isn't anymore queries than were already being done (show fanart was already being fetched via the thumbloader).

Owner

Montellese commented Jul 7, 2012

There will be more queries for the tvshow_thumb because it is done in the thumbloader for every episode. But there were only few queries that could be saved in recently added episodes (compared to recently added album songs).

Contributor

HitcherUK commented Jul 7, 2012

For consistency purposes with the other 'Thumb' labels (FolderThumb, SeasonThumb, ArtistThumb) wouldn't it be a good idea to drop the underscore?

eg Player.Property(TVShowThumb) instead of Player.Property(TVShow_Thumb)

Member

jmarshallnz commented Jul 7, 2012

@Montellese, yes, but it's being done in the same query as the fanart now which was always being done in the thumbloader per episode anyway, so is actually one query less per episode now. A caching layer might still be advisable, but I think putting it in the thumbloader or the db might be the way to go if we want that (I suspect it's only useful for mysql or very large sqlite3 databases where the db pages need to be paged out all the time).

Member

jmarshallnz commented Jul 7, 2012

@Hitcher: I um'd and ah'd about it a bit - fanart_image was what I was aiming for consistency with, but I'm happy to change it if you feel no underscore is better.

Contributor

HitcherUK commented Jul 7, 2012

Well we already use it for Container.TvshowThumb and ListItem.Property(TVShowThumb) so adding TVShow_Thumb could possibly lead to confusion down the line but certainly don't just leave it up to me. ;)

Member

jmarshallnz commented Jul 7, 2012

Hmm, where is listitem.property(tvshowthumb) set, sounds like I can remove some code...

Will make it consistent and push it in - thanks!

jmarshallnz was assigned Jul 7, 2012

@jmarshallnz jmarshallnz added a commit that referenced this pull request Jul 7, 2012

@jmarshallnz jmarshallnz Merge pull request #1130 from jmarshallnz/player_property
Player.Property() support
fff973e

@jmarshallnz jmarshallnz merged commit fff973e into xbmc:master Jul 7, 2012

Contributor

HitcherUK commented Jul 7, 2012

Member

jmarshallnz commented Jul 7, 2012

Heh - I figured it was probably me - I should have grep'd first. Enjoy access everywhere (note you have it at the listitem level as well as player now).

Contributor

HitcherUK commented Jul 8, 2012

Awesome, many thanks.

Owner

MartijnKaijser commented Jul 10, 2012

Wouldn't 'FanartImage' be better than 'Fanart_Image'? Others listitems don't have the underscore

Member

jmarshallnz commented Jul 10, 2012

If only we could rewrite 6 years of history ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment