Handle "analog" seeking in a separate handler rather than in GUIDialogSeekBar #1134

Merged
merged 2 commits into from Jul 12, 2012

Conversation

Projects
None yet
3 participants
Member

jmarshallnz commented Jul 8, 2012

This moves seek handling to a separate handler, thus ensuring that analog seeking can be done if the seekbar dialog is on screen. It fixes #11712.

As a pull req as there's build changes and a bit of reorg - should be a quick review.

@elupus elupus and 1 other commented on an outdated diff Jul 8, 2012

xbmc/Application.cpp
@@ -5308,6 +5315,16 @@ int CApplication::GetPlaySpeed() const
return m_iPlaySpeed;
}
+float CApplication::GetSeekPercentage() const
+{
+ return m_seekHandler->GetPercent();
+}
+
+bool CApplication::IsSeeking() const
+{
+ return m_seekHandler->InProgress();
+}
+
@elupus

elupus Jul 8, 2012

Member

Do we really need to put this in CApplication?

@jmarshallnz

jmarshallnz Jul 8, 2012

Member

We have to put it somewhere. It's either expose the seek handler in some way (owned by the app) or expose the 2 functions we need from it.

@jmarshallnz

jmarshallnz Jul 9, 2012

Member

@elupus: I can expose using:

const CSeekHandler *GetSeekHandler() const { return m_seekHandler; };

in Application.h if you prefer?

@elupus

elupus Jul 10, 2012

Member

Thats vetter.

Jonathan Mar... added some commits Jan 18, 2012

Jonathan Marshall [seekbar] adds seek handler rather than handling seeking directly in …
…CGUIDialogSeekBar.
124b538
Jonathan Marshall Move the seek handling to the app. Fixes problems where analog seekin…
…g didn't respond while the seekbar wasn't allowed on screen. Fixes #11712
c1398f4

jmarshallnz was assigned Jul 12, 2012

jmarshallnz merged commit 252ed09 into xbmc:master Jul 12, 2012

Member

da-anda commented on 124b538 Nov 6, 2012

Hey Jonathan, any plans to extend this seekHandler and f.e. also move the calculation for stepForward/bigStepForward out of DVDplayer into this handler, as well as all other seeking stuff (like from CApplication) into this class? Would IMO make the current seeking mess (tons of functions spread everywhere) much better.

Member

jmarshallnz replied Nov 6, 2012

@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014

@tru @LongChair tru + LongChair Fix PlexContent for all Episodes
Fixes #1134
5ddbdae

@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014

@tru tru Fix PlexContent for all Episodes
Fixes #1134
2ae3038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment