Karaoke video background player with a generic decoder class #1137

Closed
wants to merge 2 commits into
from

Projects

None yet

6 participants

@gyunaev
gyunaev commented Jul 9, 2012

As requested by Spiff :)

Same functionality as in #1126, but for Windows the files should be already there in the build system. Not for Mac though - you'll need to add new files xbmc/music/karaoke/karaokevideobackground.cpp / h and xbmc/video/FFmpegVideoDecoder.cpp /h

@gyunaev
gyunaev commented Jul 11, 2012

Any feedback?

@gyunaev
gyunaev commented Jul 11, 2012

What does "alpha" mean? :)

Is the ffmpeg library VFS-patched, i.e. its open() goes through the VFS already? At least DVDPlayer calls avformat_open_input() directly, see xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxFFmpeg.cpp

@jmarshallnz
Member

alphabetical.

@gyunaev
gyunaev commented Jul 11, 2012

Everything should be fixed by now.

@ghost
ghost commented Aug 5, 2012

the ffmpeg demuxer checks the input stream type given. it's only DVDSTREAM_TYPE_FFMPEG for a few streaming protocols, mms, rtsp. usually it's DVDSTREAM_TYPE_FILE which reads through our vfs.

@ghost
ghost commented Sep 5, 2012

rebase and inject. elupus indirectly signed off on devcon.

@gyunaev
gyunaev commented Sep 12, 2012

Will do this week once I'm finally back in CA.

rebase and inject. elupus indirectly signed off on devcon.


Reply to this email directly or view it on GitHub
#1137 (comment).

With best regards, George.
http://www.ulduzsoft.com

@ghost
ghost commented Sep 14, 2012

merge window is closed. will have to wait till october.

@leechguy
leechguy commented Apr 7, 2013

This PR seems to be obsoleted by 01a2ea0

@bulkzooi

So this can be closed?

@MartijnKaijser
Member

@bulkzooi are you a dev? No? then stay out of xbmc github

@MartijnKaijser
Member

@gyunaev
is this PR indeed obsolete as mentioned?

@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014
@tru tru Fix "Play Next" action.
Fixes #1137
cdb497f
@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014
@tru tru Fix "Play Next" action.
Fixes #1137
8981d82
@MartijnKaijser MartijnKaijser removed this from the Awaiting answer from dev milestone Jun 12, 2015
@mkortstiege mkortstiege closed this Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment