Karaoke video background player with a generic decoder class #1137

Closed
wants to merge 2 commits into from

6 participants

@gyunaev

As requested by Spiff :)

Same functionality as in #1126, but for Windows the files should be already there in the build system. Not for Mac though - you'll need to add new files xbmc/music/karaoke/karaokevideobackground.cpp / h and xbmc/video/FFmpegVideoDecoder.cpp /h

@gyunaev

Any feedback?

@gyunaev

What does "alpha" mean? :)

Is the ffmpeg library VFS-patched, i.e. its open() goes through the VFS already? At least DVDPlayer calls avformat_open_input() directly, see xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxFFmpeg.cpp

@jmarshallnz
Team Kodi member

alphabetical.

@gyunaev

Everything should be fixed by now.

@ghost

the ffmpeg demuxer checks the input stream type given. it's only DVDSTREAM_TYPE_FFMPEG for a few streaming protocols, mms, rtsp. usually it's DVDSTREAM_TYPE_FILE which reads through our vfs.

@ghost

rebase and inject. elupus indirectly signed off on devcon.

@gyunaev
@ghost

merge window is closed. will have to wait till october.

@leechguy

This PR seems to be obsoleted by 01a2ea0

@bulkzooi

So this can be closed?

@MartijnKaijser
Team Kodi member

@bulkzooi are you a dev? No? then stay out of xbmc github

@MartijnKaijser
Team Kodi member

@gyunaev
is this PR indeed obsolete as mentioned?

@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014
@tru tru Fix "Play Next" action.
Fixes #1137
cdb497f
@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014
@tru tru Fix "Play Next" action.
Fixes #1137
8981d82
@MartijnKaijser MartijnKaijser removed this from the Awaiting answer from dev milestone Jun 12, 2015
@mkortstiege mkortstiege closed this Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment