Join GitHub today
[cmake] fixes cpack dependency list generation #11370
While trying to generate deb packages from cpack I realised that the dependencies where not properly generated for binary packages. I also realised that the current implementation goes a bit about the cpack specification (Check the Note), which states that if SHLIBDEPS is ON the found dependencies will be appended to the DEPENDS of each package. Which was not what was happening with the kodi's implemention - it was overriding as the information within the txts states, which needs to be changed as well.
Documentation in each .txt template was updated to reflect the above info.
Backport will be provided when the final version of this PR is agreed upon.
Motivation and Context
Create .deb with the correct dependencies.
How Has This Been Tested?
Building .deb packages using cpack.
Screenshots (if appropriate):
Types of change
Looks good, thx.
Are you sure it's picking all the deps? I have a vague memory about problems with this approach but can't test now.
I couldn't find the note in the link you posted above. The correct link is https://cmake.org/cmake/help/v3.6/module/CPackDeb.html#variable:CPACK_DEBIAN_%3CCOMPONENT%3E_PACKAGE_DEPENDS
btw, we're missing a
@hudokkow Thanks for your comments.
I've updated the original post with the correct link, thanks for pointing that out.
About the dependencies, the resulting dependencies after generating the .debs match the required ones that @wsnipex defined in debian/control file for trusty. The only things I had to leave out, as I didn't find a way to add it, were the "misc:Depends" and "python:Depends" but I believe that those do not add any extra dependency.
I'll add kodi-game-dev.txt.in, sure. :)
Once this is done, I can build and generate deb files so you can have a look at them, or I can post here the result of