Skip to content

Dirty audio #1138

Merged
merged 3 commits into from Jul 11, 2012

1 participant

@theuni
Team Kodi member
theuni commented Jul 9, 2012

This work comes from @jmarshallnz, I'm just the PR monkey.

  1. Don't have AE constantly converting and otherwise wasting resources when there is no sound output. Saves a boatload of cpu usage on embedded platforms.
  2. Pass the status from 1 down to the sinks, so that they can choose to be smarter when there's nothing to do.

Note that for 2, we don't actually change any sink behaviors, only give them the knowledge of whether the buffer contains silence or real audio. Some sinks may be able to do nothing, while others may have to keep silence flowing. I'll leave that to the various platform devs.

Cory Fields and others added some commits Jul 9, 2012
Cory Fields [SoftAE] pass audio/silence down to the sink so it can decide if it w…
…ants to output
74ba6a5
Jonathan Marshall [SoftAE] change RunOutputStage to take in a boolean for audio (vs sil…
…ence) and to return the number of samples taken by the output stage
f5a89c1
Jonathan Marshall [SoftAE] don't process silence when we don't have to. ff3a880
@theuni theuni merged commit c1cecb9 into xbmc:master Jul 11, 2012
@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014
@tru tru Added warning dialog for when user will clear a modified PlayQueue
Fixes #1138
551150b
@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014
@tru tru Added warning dialog for when user will clear a modified PlayQueue
Fixes #1138
3874365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.