[osx] - fix refclock after refreshrate change and re-add videoscreen.delayrefreshchange #11388

Merged
merged 2 commits into from Jan 11, 2017

Projects

None yet

3 participants

@Memphiz
Member
Memphiz commented Jan 6, 2017

This fixes a problem where after changing refreshrate the VideoPlayer still uses the old fps. It also re-adds the videoscreen.delayrefreshchange which got lost somewhere during the cycle (used the same pattern as on WindowingX11.

@FernetMenta so far what we gathered i guess. Fine with this?

Also the user which reported the choppy vtb (which you fixed with the fence logic inversion) stated that its smooth now - but it gets choppy as soon as an overlay comes into play :(. So this issue is still left then.

@FernetMenta
Member

great! big step forward.
btw: the pr shows the label "Backport-Done"

@Memphiz
Member
Memphiz commented Jan 7, 2017

It shows the label backport done because i have the backport pr done too. Thought that was how it was meant to be used?

@FernetMenta
Member

maybe, not sure. backport-done somehow implies that it hit the code already.

@Memphiz
Member
Memphiz commented Jan 7, 2017

Oh i always use it as - pull request has been planted.

@MartijnKaijser
Member

any hold up for merge (and the backport)?

@MartijnKaijser
Member

jenkins build this please

@MartijnKaijser
Member

fails on windows/osx

xbmc/windowing/osx/WinSystemOSX.mm
+void CWinSystemOSX::HandleOnResetDevice()
+{
+
+ int delay = CSettings::GetInstance().GetInt("videoscreen.delayrefreshchange");
@FernetMenta
FernetMenta Jan 10, 2017 Member

CServiceBroker::GetSettings()

@Memphiz Memphiz [OSX/Windowing] - added support for videoscreen.delayrefreshchange se…
…tting again by delaying the OnResetDisplay callback - take from WindowingX11
487d712
@Memphiz
Member
Memphiz commented Jan 10, 2017

yep PR updated - sorry for that one - jenkins build this please

@MartijnKaijser
Member

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 83a4bad into xbmc:master Jan 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment