Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] PVRMananger::m_currentFile: CFileItem* -> CFileItemPtr. #11397

Merged
merged 1 commit into from Jan 9, 2017

Conversation

@ksooo
Copy link
Member

commented Jan 8, 2017

Cleanup: Replace raw pointer with smart pointer.

@Jalle19 for review?

@ksooo ksooo added this to the L 18.0-alpha1 milestone Jan 8, 2017
@ksooo ksooo requested a review from Jalle19 Jan 8, 2017
@Jalle19
Jalle19 approved these changes Jan 8, 2017
Copy link
Member

left a comment

Apart from the comment, +1

@@ -1579,9 +1571,8 @@ bool CPVRManager::PerformChannelSwitch(const CPVRChannelPtr &channel, bool bPrev

CLog::Log(LOGDEBUG, "PVRManager - %s - switching to channel '%s'", __FUNCTION__, channel->ChannelName().c_str());

// will be deleted by CPVRChannelSwitchJob::DoWork()

This comment has been minimized.

Copy link
@Jalle19

Jalle19 Jan 8, 2017

Member

Did you change this usage too? Can't really see from the diff.

This comment has been minimized.

Copy link
@ksooo

ksooo Jan 8, 2017

Author Member

Hehe, good catch, CPVRChannelSwitchJob::DoWork actually did not (!) delete it, this was a bug, which now is fixed.

This comment has been minimized.

Copy link
@ksooo

ksooo Jan 8, 2017

Author Member

CPVRChannelSwitchJob now also uses shared pointers.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2017

jenkins build this please

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2017

WIN-32 Jenkins error is not related to this PR.

@ksooo ksooo merged commit aae0eb5 into xbmc:master Jan 9, 2017
2 of 3 checks passed
2 of 3 checks passed
jenkins4kodi You are a failure. Fix the code and try again......
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ksooo ksooo deleted the ksooo:pvr-manager-currentfile-type-smartpointer branch Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.