Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[Fix] For inconsistent 'play from here' context menu behaviour.... #1143

Merged
merged 1 commit into from

2 participants

@bossanova808

...the item shouldn't need a video info tag for this option to be available.

See: http://forum.xbmc.org/showthread.php?tid=133393

This is a tiny thing it would be Eden 11.1 backport friendly.

I have probably commented trivial code, sorry!

@jmarshallnz jmarshallnz merged commit a85cf75 into xbmc:master
@tru tru referenced this pull request from a commit in RasPlex/plex-home-theatre
@tru tru Fix behaviour of switching to fullscreen mode.
We are now switching to video fullscreen at all times when you start
playing a new video and we are NOT switching to Visualization/Now
Playing for music, you will have to do that manually.

Fixes #1143
a0039ad
@tru tru referenced this pull request from a commit in RasPlex/plex-home-theatre
@tru tru Fix behaviour of switching to fullscreen mode.
We are now switching to video fullscreen at all times when you start
playing a new video and we are NOT switching to Visualization/Now
Playing for music, you will have to do that manually.

Fixes #1143
a30ad5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 10, 2012
  1. @bossanova808

    Fix for playfromhere context menu item - the item shouldn't need a vi…

    bossanova808 authored
    …deo info tag for this option to be available.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +3 −1 xbmc/video/windows/GUIWindowVideoBase.cpp
View
4 xbmc/video/windows/GUIWindowVideoBase.cpp
@@ -1230,7 +1230,9 @@ void CGUIWindowVideoBase::GetContextButtons(int itemNumber, CContextButtons &but
{
buttons.Add(CONTEXT_BUTTON_RESUME_ITEM, GetResumeString(*(item.get()))); // Resume Video
}
- if (item->HasVideoInfoTag() && !item->m_bIsFolder && m_vecItems->Size() > 1 && itemNumber < m_vecItems->Size()-1)
+ //if the item isn't a folder, is a member of a list rather than a single item
+ //and we're not on the last element of the list, then add the 'play from here' option
+ if (!item->m_bIsFolder && m_vecItems->Size() > 1 && itemNumber < m_vecItems->Size()-1)
{
buttons.Add(CONTEXT_BUTTON_PLAY_AND_QUEUE, 13412);
}
Something went wrong with that request. Please try again.