Add support for SMB File Rename if same share #11446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file to be moved in ActionMove is in the same SMB share it can be renamed.
|
jenkins build and merge this please |
|
It seems the same is true for Dav and NFS, so those might also be added. |
MartijnKaijser
added
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the file to be moved in ActionMove is in the same SMB share it can be renamed.
Motivation and Context
Copying a file instead of renaming is inefficient as it has to be transferred twice over the network. This makes move operations a server side operation.
How Has This Been Tested?
Tested in my own setup.
Types of change
Checklist:
(replaces #11445)