Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR][Settings] Remove 'hide connection lost warning' setting and code. #11500

Merged

Conversation

@ksooo
Copy link
Member

commented Jan 20, 2017

Cleanup. We do not need this setting anymore since we have "async connect" for pvr client addons (introduced with krypton), because we do no longer try to load addons in a (potential endless) loop.

Tested on latest master on macOS.

@Jalle19 like always, for the review? ;-)

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2017

jenkins build this please

@ksooo ksooo merged commit b7892b8 into xbmc:master Jan 22, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@ksooo ksooo deleted the ksooo:pvr-remove-setting-hideconnectionlostwarning branch Jan 22, 2017
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.