GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
As discussed with @jmarshallnz we want to reduce the number of sets per movie to only one. This is in line with how TMDb works. Furthermore having only one set per movie reduces the necessary queries because the setid of the set to which a movie belongs can be stored in the movieview and does not require an extra query (or JOIN query) to setlinkmovie etc.
Obviously users currently having multiple sets will have to re-organize their library and will start screaming at us but with the additiona of tags (which was merged in this month's merge window) there's a (IMO better) alternative to movie sets.
As stated in the commit message of the second commit this will break backwards compatibility of JSON-RPC. I could change the code in CVideoInfoTag and hack in backwards compatibility if we would want that.
+1 (no code review)
I removed CVideoDatabase::AddSetToMovie and integrated that functionality directly into the UPDATE query in CVideoDatabase::SetDetailsForMovie().
videodb: only allow one set per movie
jsonrpc: set and setid are single values now (breaks backwards-compat…
Merge pull request #1161 from Montellese/one_set_to_rule_them_all
videodb: allow only one set per movie
Switch order of context items.