Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

videodb: allow only one set per movie #1161

Merged
merged 2 commits into from Aug 6, 2012

Conversation

Projects
None yet
3 participants
Owner

Montellese commented Jul 15, 2012

As discussed with @jmarshallnz we want to reduce the number of sets per movie to only one. This is in line with how TMDb works. Furthermore having only one set per movie reduces the necessary queries because the setid of the set to which a movie belongs can be stored in the movieview and does not require an extra query (or JOIN query) to setlinkmovie etc.

Obviously users currently having multiple sets will have to re-organize their library and will start screaming at us but with the additiona of tags (which was merged in this month's merge window) there's a (IMO better) alternative to movie sets.

As stated in the commit message of the second commit this will break backwards compatibility of JSON-RPC. I could change the code in CVideoInfoTag and hack in backwards compatibility if we would want that.

Member

mkortstiege commented Jul 15, 2012

+1 (no code review)

Member

jmarshallnz commented Jul 16, 2012

Looks fine.

@ghost ghost assigned Montellese Jul 16, 2012

Owner

Montellese commented Jul 16, 2012

I removed CVideoDatabase::AddSetToMovie and integrated that functionality directly into the UPDATE query in CVideoDatabase::SetDetailsForMovie().

@Montellese Montellese referenced this pull request Jul 17, 2012

Merged

JSON-RPC: cleanup #1174

Montellese added a commit that referenced this pull request Aug 6, 2012

@Montellese Montellese merged commit 8f68fe6 into xbmc:master Aug 6, 2012

tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014

tru added a commit to RasPlex/plex-home-theatre that referenced this pull request May 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment